Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements with didactic value #22

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

pimoGit
Copy link

@pimoGit pimoGit commented May 5, 2018

AUTH:

  • made a compressed version of form validation;
  • fixed a bug about persistence of error messages across pages;
  • refactoring signUp and signIn actions, no repeated code anymore;
  • refactoring/optimization signUp component, leaving also the original version commented out.

MIDDLEWARES

  • added key to the list items;
  • changed a callback function on props.map in user_list.js component to make it clearer.

TESTING:

  • differentiated the state name from the prop mapped name on comment_list_test to make it clearer.

ALL:

  • added some comments;
  • got rid of Gmaps useless reference.

I think all these changes have a didactic value.

…code and centralized it in a external function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant